Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TortoiseGit steals GitHub Desktop links #4754

Closed
kb-1000 opened this issue May 22, 2018 · 8 comments
Closed

TortoiseGit steals GitHub Desktop links #4754

kb-1000 opened this issue May 22, 2018 · 8 comments

Comments

@kb-1000
Copy link

kb-1000 commented May 22, 2018

Is your feature request related to a problem? Please describe.
I've installed both TortoiseGit and GitHub Desktop on my windows system. Since TortoiseGit was installed after GitHub Desktop, it has configured itself as default for x-github-client:// links, but I don't want to use it.

Describe the solution you'd like
An option should be added to File -> Options... to set GitHub Desktop as default for those links. It shouldn't appear when it's already configured as default.

Describe alternatives you've considered
Another option could be to show a dialog whenever GitHub Desktop starts, but that could spam users.

Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this. This will help the core team understand how the feature would work, and assist with future work like documentation.
Screenshots or mockups here are a great help!
@steveward steveward added the more-info-needed The submitter needs to provide more information about the issue label May 22, 2018
@steveward
Copy link
Member

Thanks for opening this @kaeptmblaubaer1000.

What is the specific browser that you are using? I can provide a solution for you to reset the protocol handler associated with those links.

Another option could be to show a dialog whenever GitHub Desktop starts, but that could spam users.

If you are using Google Chrome you can turn off the ability for Chrome to set a default application for those types of links by going to chrome://settings/handlers and turning off the Allow sites to ask to become default handlers for protocols option.

@kb-1000
Copy link
Author

kb-1000 commented May 22, 2018

@steveward I'm using Chrome, but TortoiseGit is a desktop application (https://gitlab.com/tortoisegit/tortoisegit). I'm unable to uninstall it since some chocolatey package I need marks it as a dependency.

@shiftkey
Copy link
Member

shiftkey commented May 22, 2018 •
edited

@kaeptmblaubaer1000 thanks for the feedback.

We ensure our protocol handlers are up to date on each launch, so I'm not sure how much more aggressive we could be here:

desktop/app/src/main-process/main.ts

Lines 180 to 188 in 7f1e492

app.on('ready', () => {
if (isDuplicateInstance || handlingSquirrelEvent) {
return
}
readyTime = now() - launchTime
setAsDefaultProtocolClient('x-github-client')

I think this is something that needs to be reported to TortoiseGit, as it's not clear to me from the release notes whether this is configurable (it's set at installation time?).

@shiftkey shiftkey removed the more-info-needed The submitter needs to provide more information about the issue label May 23, 2018
@shiftkey
Copy link
Member

Since TortoiseGit was installed after GitHub Desktop, it has configured itself as default for x-github-client:// links, but I don't want to use it.

Closing this out as something that Desktop doesn't have control over. I'd recommend contacting TortoiseGit Support about the behaviour.

@kb-1000
Copy link
Author

kb-1000 commented May 24, 2018

https://gitlab.com/tortoisegit/tortoisegit/issues/3215

@kb-1000
Copy link
Author

kb-1000 commented May 24, 2018 •
edited

@shiftkey from TortoiseGit issue tracker:

It's not enabled by default, I just re-checked the source. However, we tell Windows that TortoiseGit is capable of handling such URLs, but we don't register it, maybe the GitHub client is not correctly registering it (there was a recent change in Windows 10).

@lock lock bot locked as resolved and limited conversation to collaborators Jul 23, 2018
@desktop desktop unlocked this conversation Sep 27, 2018
@steveward steveward mentioned this issue Dec 26, 2018
Closed
@tobias-loew
Copy link

I the problem is the missing registration of GitHubDesktop at HKEY_LOCAL_MACHINE\SOFTWARE\RegisteredApplications and HKEY_LOCAL_MACHINE\SOFTWARE\GitHubDesktop.
I described the solution here: https://stackoverflow.com/a/57905263/1997370
Please add the missing registration to the GitHubDesktop-installer

@tobias-loew tobias-loew mentioned this issue Sep 13, 2019
Open
@ouliuquan
Copy link

Don't someone real to deal with the problem? Not just talking without a test.

@niik niik mentioned this issue Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shiftkey @steveward @tobias-loew @kb-1000 @ouliuquan